Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: import error #324

Merged
merged 13 commits into from
Feb 8, 2023
Merged

hotfix: import error #324

merged 13 commits into from
Feb 8, 2023

Conversation

fletchapin
Copy link
Member

Pull request recommendations:

  • Name your pull request {your development type}: {short description}. Ex: Feature: flocculator validation
  • Link to any relevant issue in the PR description. Ex: Resolves Remove all hard-coded constants from utility files #12, adds flocculator validation
  • Provide context of changes.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Resolves #322 by removing string from the beginning of unit_definitions.txt. Also fixes the SyntaxWarning by changing is to == with string comparisons

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #324 (194442d) into master (cc40815) will not change coverage.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   89.56%   89.56%           
=======================================
  Files          29       29           
  Lines        3047     3047           
=======================================
  Hits         2729     2729           
  Misses        318      318           
Impacted Files Coverage Δ
aguaclara/core/constants.py 100.00% <ø> (ø)
aguaclara/core/pipes.py 98.48% <ø> (ø)
aguaclara/research/peristaltic_pump.py 100.00% <ø> (ø)
aguaclara/design/floc.py 90.24% <33.33%> (ø)
aguaclara/core/cache.py 94.28% <100.00%> (ø)
aguaclara/core/units.py 81.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fletchapin fletchapin merged commit 4760537 into master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError on import from aguaclara.core.constants Remove all hard-coded constants from utility files
1 participant