import ERTP types #104
import ERTP types #104
Conversation
| @@ -260,8 +243,10 @@ export const watchWallet = ( | |||
|
|
|||
| for await (const update of iterateEach(follower)) { | |||
| console.debug('wallet update', update); | |||
| // @ts-expect-error xxx | |||
There was a problem hiding this comment.
Just wondering, what was the error here? Maybe we can provide a type for the follower, or iterateEach<>? Or casting doesn't support it well enough..
| @@ -100,6 +82,7 @@ export const watchWallet = ( | |||
| smartWalletStatusNotifierKit.updater.updateState( | |||
| harden({ provisioned: true }), | |||
| ); | |||
| // @ts-expect-error xxx | |||
There was a problem hiding this comment.
It might be possible to provide a type to chainStorageWatcher.watchLatest to resolve this
| /** @type { import('@agoric/smart-wallet/src/smartWallet.js').CurrentWalletRecord['offerToPublicSubscriberPaths'] | null } */ ( | ||
| null | ||
| ), | ||
| /** @type { import('@agoric/smart-wallet/src/smartWallet.js').CurrentWalletRecord['offerToPublicSubscriberPaths'] | null } */ null, | ||
| ); | ||
|
|
||
| const walletUpdatesNotifierKit = makeNotifierKit( |
There was a problem hiding this comment.
Can we provide a type arg to makeNotifierKit instead of casting here?
There was a problem hiding this comment.
this was just a prettier change. I forgot to convert from jsdoc so TS isn't even seeing it. I'll fix
| * @param {string} networkConfigHref | ||
| * @param {string=} caption | ||
| * @param networkConfigHref | ||
| * @param [caption] |
There was a problem hiding this comment.
Are these doc comments necessary now that we have type params?
There was a problem hiding this comment.
The jsdoc lint plugin is enforcing it when there's any jsdoc comment. I'd be fine disabling that rule. WDYT?
There was a problem hiding this comment.
second thought, I think that would risk defining some of the params by jsdoc and not others.
| @@ -45,11 +30,14 @@ const zeroFee = () => { | |||
|
|
|||
| /** | |||
| * Use a signing client to | |||
There was a problem hiding this comment.
Looks like this comment was previously messed up. Should be something like "Use a signing client to create a signer for Agoric-specific transactions"
|
I fixed some build errors and typedocs here: #106 Tested with dapp-offer-up and seems to work. |
thanks, I cherry-picked that into this. (I didn't merge because my local branch had already moved from the remote) |
closes: #103
Description
Converts packages/web-component to
.tsso it can import that actual ERTP typesSecurity Considerations
n/a, types
Scaling Considerations
n/a, types
Documentation Considerations
none
Testing Considerations
CI suffices