chore: Remove Background Voting Loop #59
Conversation
amessbee
changed the title
| echo "done" | ||
| } | ||
|
|
||
| waitForBlock() ( |
There was a problem hiding this comment.
looks like waitForBlock is still in use. I see a call to it below.
There was a problem hiding this comment.
Noted. In dapp-offer-up, we are pulling the definition of waitForBlock from /usr/src/upgrade-test-scripts/env_setup.sh rather than defining it here. I would rather keep run-chain.sh identical in both dapps. Let me know which one is preferable.
contract/scripts/run-chain.sh
Outdated
|
|
||
| make -C /workspace/contract mint100 | ||
|
|
||
| # bring back chain process to foreground | ||
| wait | ||
| wait |
There was a problem hiding this comment.
Is that removing the final newline? Let's not do that.
contract/scripts/run-chain.sh
Outdated
| wait |
There was a problem hiding this comment.
This is a fixup (a change to some earlier change in this PR), not a fix (a change in the behavior of the code w.r.t. what was previously released or merged). In agoric-sdk, we auto-squash on merge, but I don't think that's set up here, so please squash and force-push.
Not critical, but let's work toward Tidy Commit History in general.
amessbee
force-pushed
the
ms/remove-background-voting-loop
branch
3 times, most recently
from
0500327
to
9a1bf00
Compare
amessbee
force-pushed
the
ms/remove-background-voting-loop
branch
from
9a1bf00
to
2639959
Compare
Duplicating similar work in
dapp-offer-upof removing voting loop running in the background.