ci: add integration test to GitHub Action #24
Conversation
| done | ||
| ' | ||
| - name: yarn start:contract | ||
| run: yarn start:contract |
There was a problem hiding this comment.
Here's hoping we can test that the contracts actually got started.
One way is:
agoric follow -lF :published.agoricNames.instance | grep sellConcertTickets
but that presumes the agoric CLI is available; I'm not sure that's the case.
agoric follow -lF ... is just an HTTP GET, so it can be done with curl too.
I'm working on running the tests for contract functionality in an end-to-end context too. But we're not quite there yet.
There was a problem hiding this comment.
We do now! Jim's slides this morning gave me an idea and we're testing that. Though I don't know why the CI couldn't see swaparoo contract onchain. The other 2 contracts are available on based on the curl response.
Ref: https://github.com/Agoric/dapp-agoric-basics/actions/runs/8332287701/job/22801091735?pr=24
There was a problem hiding this comment.
We do now!
nice!
I don't know why the CI couldn't see swaparoo contract onchain.
very strange. it's certainly in the ci log: [\\\\\\\"sellConcertTickets\\\\\\\",\\\\\\\"$23.Alleged: InstanceHandle\\\\\\\"]
There was a problem hiding this comment.
It could grep sellConcertTickets and postalService, but not swaparoo
I tried to CTRL+F on the blob and I couldn't find swaparoo in the data blob. Do we need to wait for some time before curling and greping?
There was a problem hiding this comment.
oic. I was reading too quickly.
I'm not sure what's up with swaparoo there. But the way it's deployed changes significantly with the addition of governance (#21) so I'm not inclined to worry about it now.
.github/workflows/pr.yml
Outdated
| - name: Wait for Docker container to be ready | ||
| run: | | ||
| timeout 180 bash -c ' | ||
| TARGET_HEIGHT=1001 |
There was a problem hiding this comment.
This was a bit of a hack to make sure all of the (replay?) is complete before submitting new tx's. This number might be a bit higher now with the addition of more proposals to a3p. I'm not sure of a good way to make this more dynamic, or if a different solution could be sourced from a3p.
There was a problem hiding this comment.
... or if a different solution could be sourced from a3p.
Yeah I think so, filed Agoric/agoric-3-proposals#130
And bump the block height threshold for being healthy
Adding an
integrationjob to verify this project can build and contract can deploy