feat: index liquidation state timings #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toliaqat
reviewed
Apr 27, 2024
src/mappings/events/vaults.ts
Outdated
| @@ -55,6 +55,14 @@ export const vaultsEventKit = (block: any, data: any, module: string, path: stri | |||
| vault.debt = payload?.debtSnapshot?.debt?.__value; | |||
| vault.balance = payload?.locked?.__value; | |||
| vault.state = payload?.vaultState; | |||
|
|
|||
| if (vault.state === 'liquidating' && !vault.liquidationStartedAt) { | |||
| vault.liquidationStartedAt = block.block.header.time; | |||
There was a problem hiding this comment.
While in the liquidating state, if there is a change in any other field, we will get a state_change event, and at that time, this if condition will be true and this will update the liquidationStartedAt time, which is not correct anymore. The liquidationStartedAt should only have time only first time this state changed into liquidation.
Same is true for liquidatedAt.
rabi-siddique
force-pushed
the
rs-index-liquidation-states
branch
3 times, most recently
from
35891da
to
3fe50b0
Compare
toliaqat
reviewed
Apr 27, 2024
| @@ -17,6 +17,9 @@ export const EVENT_TYPES = { | |||
| STORAGE: "storage", | |||
| SUBMIT_PROPOSAL: "submit_proposal", | |||
| TRANSFER: "transfer", | |||
| LIQUIDATING: "liquidating", | |||
There was a problem hiding this comment.
EVENT_TYPES are used for different purposes. These are states of Vaults, so a new enum called VAULT_STATES will be better.
rabi-siddique
force-pushed
the
rs-index-liquidation-states
branch
from
3fe50b0
to
13e11ee
Compare
rabi-siddique
force-pushed
the
rs-index-liquidation-states
branch
from
13e11ee
to
fd4dffa
Compare
toliaqat
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.