Feat: MsgInstallBundle indexing #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frazarshad
changed the title
|
|
||
| await bundleRecord.save(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should wrap this section of the code in a try-catch block to catch and log any errors that may occur.
There was a problem hiding this comment.
catching the error would result in skipping this message entirely. Throwing an error allows the indexing to stop at that point.
that is our current implementation for all of our functions
src/mappings/utils.ts
Outdated
| return address; | ||
| }; | ||
|
|
||
| export const getAddressFromUint8Array = (uint8Array: Array<number>, chainPrefix: string = 'agoric') => { |
There was a problem hiding this comment.
You can use the Uint8Array type,
export const getAddressFromUint8Array = (uint8Array: Uint8Array, chainPrefix: string = 'agoric') => {
There was a problem hiding this comment.
If you change the type, you will need to make this change on line 106:
const shaHashUint8Array = new Uint8Array(shaHash.slice(0, 20));
const address = getAddressFromUint8Array(shaHashUint8Array);There was a problem hiding this comment.
PS: I haven't tested the functionality implemented in this PR. Just changed the code and there were no compilation errors.
rabi-siddique
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds indexing for
MsgInstallBundlemessagesCompare data in picture against this transaction