test: fusdc multichain #10618

0xpatrickdev · 2024-12-04T16:09:28Z

Description

Adds multichain-testing test for FUSDC happy path. Includes:

accepting oracle operator invitations
funding liquidity pool with bridged USDC
simulating advance request via mockCctpTxEvidence submissions
simulating CCTP mint and settlement flow
LP returns shares for more USDC than deposited

Ensures advance appears in EUD account, Liquidity Pool is repaid, and corresponding TxStatus updates are recorded in vstorage.

Security Considerations

None, test code.

Scaling Considerations

None really. For CI load, the test takes about 32 seconds after setup.

Documentation Considerations

None

Testing Considerations

PR only includes tests and test support.

Upgrade Considerations

None

cloudflare-workers-and-pages · 2024-12-04T16:12:07Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`e860814`
Status:	✅ Deploy successful!
Preview URL:	https://92b3e916.agoric-sdk.pages.dev
Branch Preview URL:	https://pc-fusdc-multichain.agoric-sdk.pages.dev

View logs

github-actions · 2024-12-06T00:54:47Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

dckc

I gotta run.

I rushed this review a little, so you may want more eyes. But as you say, only test code, so low risk.

dckc · 2024-12-11T00:16:57Z

multichain-testing/test/fast-usdc/config.ts

+harden(oracleMnemonics);
+
+export const makeFeedPolicy = (nobleAgoricChannelId: IBCChannelID) => {
+  return JSON.stringify({


can the caller JSON.stringify it? It would be nice to @returns { FeedPolicy }.

dckc · 2024-12-11T00:20:50Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+  await startContract(contractName, contractBuilder, {
+    oracle: keys(oracleMnemonics).map(n => `${n}:${wallets[n]}`),
+    usdcDenom: usdcDenom,
+    feedPolicy: makeFeedPolicy(nobleAgoricChannelId),


startContract wants a string for feedPolicy? ah... it's just taking flags(). Let's stringify here.

dckc · 2024-12-11T00:22:18Z

multichain-testing/test/fast-usdc/config.ts

+      Arbitrum: {
+        cctpTokenMessengerAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
+        chainId: 42161,
+        confirmations: 2,
+        nobleContractAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',


are those arbitrary values chosen by us?

Or is there an external design constraint here? If so, let's please cite it.

For context: https://developers.circle.com/stablecoins/evm-smart-contracts

That's for cctpTokenMessengerAddress, but nobleContractAddress could be the same or different. From codecider:

nobleContractAddress: Hex; - The address of Noble's wrapper contract that users interact with via NobleExpress - msg.sender of DepositAndBurn must be this address to prevent users from calling replaceDepositForBurn

I'm not sure where exactly we'd find the noble wrapper contract addresses (if they exist). Might need to ask those folks directly.

yes, let's add that pointer, @samsiegart

I wonder how to track down the date the contract was deployed. A date is always a nice thing to have in a citation.

See #10679. Feel free to provide suggestions for a better name in PR or offline

on 2nd thought, to answer my own question, yes, we did choose this address: this is a test config. If we want to re-deploy the contract at a different address in our test env, we don't have to coordinate with anybody else.

dckc · 2024-12-11T00:25:51Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+    provisionSmartWallet,
+    startContract,
+  } = common;
+  deleteTestKeys(accounts).catch();


we want/need this to finish before setupTestKeys(...), right?

Suggested change

deleteTestKeys(accounts).catch();

await deleteTestKeys(accounts).catch();

we don't have lint for dangling promises in multichain-testing?

dckc · 2024-12-11T00:26:45Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+  deleteTestKeys(accounts).catch();
+  const wallets = await setupTestKeys(accounts, values(oracleMnemonics));
+
+  // provision oracle wallets first so invitation deposits don't fail


I/we should check that product is OK with this constraint.

dckc · 2024-12-11T00:39:40Z

multichain-testing/tools/random.ts

+export function makeRandomDigits(digits = 2n) {
+  if (digits < 1n) throw new Error('digits must be positive');
+  const maxValue = Math.pow(10, Number(digits)) - 1;
+  const num = Math.floor(Math.random() * (maxValue + 1));


Math.random is ambient authority. There's only 1 caller of this function. Please move it to the test script or inline it so that we're not exporting functions that close over ambient authority.

This seemed like too much to inline - I made randomNumber a parameter and put the Math.random() call in the test file.

dckc · 2024-12-11T00:45:44Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+        invitationSpec: {
+          source: 'purse',
+          instance,
+          description: 'oracle operator invitation', // TODO export/import INVITATION_MAKERS_DESC


yeah; we should have a helper in @agoric/fast-usdc/tools/ for building this whole offer spec.

check out https://github.com/Agoric/agoric-sdk/blob/master/packages/inter-protocol/src/clientSupport.js#L429-L455

Created #10677

dckc · 2024-12-11T00:46:18Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+      retryUntilCondition(
+        () => vstorageClient.queryData(`published.wallet.${addr}.current`),
+        ({ offerToUsedInvitation }) => {
+          return offerToUsedInvitation[0][0] === `${name}-accept`;


can we be sure this is the 1st offer in that table?

In this test, yes, because we are using fresh mnemonics

dckc · 2024-12-11T00:49:03Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+  // register forwarding address on noble
+  const txRes = nobleTools.registerForwardingAcct(
+    nobleAgoricChannelId,
+    recipientAddress,
+  );


hm. is this step in the diagrams in our current spec?
IOU a check.

I am a little hazy - but iirc the UI's backend service and/or OCW does this step

ah yes... it's there. arrow 4.

sequenceDiagram title Fast USDC Transaction Process participant NEA as Noble Express app<br/>[Browser] participant NC as Noble Chain<br/>[Noble] rect rgb(240, 248, 255) NEA-->>NC: Register NFA end

Loading

dckc · 2024-12-11T00:49:27Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+
+  const mintAmount = 800_000n;
+
+  // TODO export CctpTxEvidence type


yikes!

This is a good test of the package, isn't it?

+1. I put exporting types as a req for: #10677

github-actions · 2024-12-11T01:43:52Z

Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label.

samsiegart

So cool to see this working!

samsiegart · 2024-12-11T06:24:23Z

multichain-testing/test/fast-usdc/config.ts

+      Arbitrum: {
+        cctpTokenMessengerAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',
+        chainId: 42161,
+        confirmations: 2,
+        nobleContractAddress: '0x19330d10D9Cc8751218eaf51E8885D058642E08A',


For context: https://developers.circle.com/stablecoins/evm-smart-contracts

That's for cctpTokenMessengerAddress, but nobleContractAddress could be the same or different. From codecider:

nobleContractAddress: Hex; - The address of Noble's wrapper contract that users interact with via NobleExpress - msg.sender of DepositAndBurn must be this address to prevent users from calling replaceDepositForBurn

I'm not sure where exactly we'd find the noble wrapper contract addresses (if they exist). Might need to ask those folks directly.

samsiegart · 2024-12-11T06:33:47Z

multichain-testing/test/fast-usdc/fast-usdc.test.ts

+      () => vstorageClient.queryData(`published.${contractName}.poolMetrics`),
+      ({ shareWorth }) =>
+        !isGTE(currShareWorth.numerator, shareWorth.numerator),
+      'share worth numerator increases from deposit',


I suppose this is reasonable for testing it worked. It would also be good to verify that the pool shares were received, but I think we can do that implicitly in the todo withdrawal test below.

doOffer checks that numWantsSatisfied is 1, so we can have confidence the pool shares were received.

No harm in explicitly checking in the test though, so I fixed up to include that. Also closed out the test.todo('lp withdraws')

- rename `nobleContractAddress` to `attenuatedCttpBridgeAddress` - include jsdoc comments for `ChainPolicy` type - removed `chainType` from `ChainPolicy`. unused and should have been an enum. not needed for OCW currently

- include `chainInfo` and `assetInfo` as common builder options for orchestration contracts

- in the testing environment, we might see multiple USDC entries in `vbankAsset`. This change ensures the `byName` record contains the values needed for the test, reliant on the consistent ordering currently present in `vbankAsset` entries

- get rid of dangling promise and await something we actually rely on

0xpatrickdev added the force:integration Force integration tests to run on PR label Dec 4, 2024

0xpatrickdev force-pushed the pc/fusdc-multichain branch from 5bc8a9b to db72909 Compare December 5, 2024 23:23

0xpatrickdev changed the base branch from master to pc/fusdc-multichain-support December 5, 2024 23:24

0xpatrickdev force-pushed the pc/fusdc-multichain branch from db72909 to cfd26c8 Compare December 6, 2024 00:03

Base automatically changed from pc/fusdc-multichain-support to master December 6, 2024 00:54

0xpatrickdev mentioned this pull request Dec 6, 2024

chore: fusdc vstorage #10639

Merged

0xpatrickdev force-pushed the pc/fusdc-multichain branch from cfd26c8 to af06ac9 Compare December 10, 2024 01:00

0xpatrickdev changed the base branch from master to pc/fusdc-vstorage-updates December 10, 2024 01:01

0xpatrickdev force-pushed the pc/fusdc-vstorage-updates branch from e3d94c3 to bf7b154 Compare December 10, 2024 18:11

0xpatrickdev force-pushed the pc/fusdc-multichain branch from ad78498 to a6faf6b Compare December 10, 2024 22:34

0xpatrickdev force-pushed the pc/fusdc-vstorage-updates branch 2 times, most recently from 21d5049 to 287e5be Compare December 10, 2024 22:57

0xpatrickdev force-pushed the pc/fusdc-multichain branch 4 times, most recently from 1c5abba to ec38514 Compare December 11, 2024 00:06

0xpatrickdev marked this pull request as ready for review December 11, 2024 00:09

0xpatrickdev requested a review from a team as a code owner December 11, 2024 00:09

0xpatrickdev requested review from AgoricTriage, turadg, dckc and samsiegart December 11, 2024 00:09

dckc approved these changes Dec 11, 2024

View reviewed changes

0xpatrickdev force-pushed the pc/fusdc-vstorage-updates branch from 287e5be to 475e720 Compare December 11, 2024 00:56

0xpatrickdev force-pushed the pc/fusdc-multichain branch from ec38514 to 6dd673e Compare December 11, 2024 01:04

Base automatically changed from pc/fusdc-vstorage-updates to master December 11, 2024 01:43

samsiegart approved these changes Dec 11, 2024

View reviewed changes

turadg removed their request for review December 11, 2024 16:54

0xpatrickdev force-pushed the pc/fusdc-multichain branch from 6dd673e to 6a891c3 Compare December 11, 2024 18:26

0xpatrickdev added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Dec 11, 2024

dckc mentioned this pull request Dec 11, 2024

Perf measurement and profiling w/multichain #10595

Open

1 task

0xpatrickdev force-pushed the pc/fusdc-multichain branch from ba19ac0 to 4ed677f Compare December 11, 2024 22:50

0xpatrickdev changed the base branch from master to pc/fusdc-bech32-hooks December 11, 2024 22:50

0xpatrickdev force-pushed the pc/fusdc-bech32-hooks branch 2 times, most recently from f081d9f to b9c275c Compare December 11, 2024 23:18

0xpatrickdev force-pushed the pc/fusdc-multichain branch from 4ed677f to d99ae45 Compare December 11, 2024 23:23

0xpatrickdev force-pushed the pc/fusdc-bech32-hooks branch 3 times, most recently from ba4fce5 to d369f08 Compare December 12, 2024 01:47

0xpatrickdev added 7 commits December 11, 2024 20:48

chore: ChainPolicy schema

075c1e5

- rename `nobleContractAddress` to `attenuatedCttpBridgeAddress` - include jsdoc comments for `ChainPolicy` type - removed `chainType` from `ChainPolicy`. unused and should have been an enum. not needed for OCW currently

chore: setupTestKeys optionally takes mnemonics

7b1395b

chore: export denom tools

edebcc7

chore: WalletDriver type

1beafd7

refactor: commonBuilderOpts

b10ae96

- include `chainInfo` and `assetInfo` as common builder options for orchestration contracts

chore: flags supports mutli option

124c5c7

chore: ensure latest view on vbank entries

f1a722f

- in the testing environment, we might see multiple USDC entries in `vbankAsset`. This change ensures the `byName` record contains the values needed for the test, reliant on the consistent ordering currently present in `vbankAsset` entries

0xpatrickdev force-pushed the pc/fusdc-multichain branch from d99ae45 to 26486cf Compare December 12, 2024 02:02

0xpatrickdev added 3 commits December 11, 2024 21:06

test: fast-usdc advance happy path

19552e4

chore: await deleteTestKeys

a1f6934

- get rid of dangling promise and await something we actually rely on

chore: ava failFast: true

e860814

0xpatrickdev force-pushed the pc/fusdc-multichain branch from 26486cf to e860814 Compare December 12, 2024 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fusdc multichain #10618

test: fusdc multichain #10618

0xpatrickdev commented Dec 4, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 6, 2024

dckc left a comment

dckc Dec 11, 2024

dckc Dec 11, 2024

dckc Dec 11, 2024

samsiegart Dec 11, 2024

dckc Dec 11, 2024

0xpatrickdev Dec 11, 2024

dckc Dec 11, 2024

dckc Dec 11, 2024

dckc Dec 11, 2024

turadg Dec 11, 2024

dckc Dec 11, 2024

0xpatrickdev Dec 11, 2024

dckc Dec 11, 2024

turadg Dec 11, 2024

0xpatrickdev Dec 11, 2024

dckc Dec 11, 2024

0xpatrickdev Dec 11, 2024

dckc Dec 11, 2024

0xpatrickdev Dec 11, 2024

dckc Dec 11, 2024

dckc Dec 11, 2024

0xpatrickdev Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

samsiegart left a comment

samsiegart Dec 11, 2024

samsiegart Dec 11, 2024

0xpatrickdev Dec 11, 2024

	deleteTestKeys(accounts).catch();
	await deleteTestKeys(accounts).catch();


		const mintAmount = 800_000n;

		// TODO export CctpTxEvidence type

test: fusdc multichain #10618

Are you sure you want to change the base?

test: fusdc multichain #10618

Conversation

0xpatrickdev commented Dec 4, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Dec 4, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

github-actions bot commented Dec 6, 2024

dckc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xpatrickdev Dec 12, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2024

samsiegart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xpatrickdev commented Dec 4, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 4, 2024 •

edited

Loading

0xpatrickdev Dec 12, 2024 •

edited

Loading