feat(fast-usdc): core-eval to change fastUsdc.feedPolicy #10609
Conversation
|
I don't get this ci error: It's complaining about the 1st import from fast-usdc, but it thinks the 2nd one is just fine: import { configurations } from '@agoric/fast-usdc/src/utils/deploy-config.js';
import { MockCctpTxEvidences } from '@agoric/fast-usdc/test/fixtures.js'; |
Deploying agoric-sdk with
|
| Latest commit: |
8ded3d8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c6ca88ca.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-fu-policy-update.agoric-sdk.pages.dev |
| USDC: await E(USDCissuer).getBrand(), | ||
| }); | ||
| const { feedPolicy } = fromExternalConfig( | ||
| config?.options, // just in case config is missing somehow |
There was a problem hiding this comment.
yes, but this way, we get a pattern mismatch diagnostic instead of a "can't get .options property of undefined" error.
It's evidently not worth the bother, though. taking it out.
| @@ -252,6 +278,16 @@ export default async (homeP, endowments) => { | |||
| return JSON.parse(feedPolicy); | |||
| }; | |||
|
|
|||
| if (update) { | |||
There was a problem hiding this comment.
This isn't really a concern of init fast-usdc, right?
Please have a separate script or include a comment here and at the top explaining why not.
There was a problem hiding this comment.
I could rename it to fast-usdc.builder.js.
I'll try a separate script first to see how much code duplication there is.
There was a problem hiding this comment.
init is a misnomer anyway.
There was a problem hiding this comment.
separate script is ~60 lines... about half is duplicated. Not so much that it's worth coupling the two purposes.
dckc
force-pushed
the
dc-fu-policy-update
branch
from
631f763 to
9c11a05
Compare
- use deploy config from fast-usdc package
dckc
force-pushed
the
dc-fu-policy-update
branch
from
9c11a05 to
8ded3d8
Compare
closes: #10507
Description
Testing Considerations
1 happy-path test:
Aside from option parsing in the builder, validation with patterns makes for essentially straight-line code.
Security / Documentation Considerations
The whole feedPolicy, for all chains, is updated at once. If the goal is to change a property for just 1 chain, it's important to keep the properties in tact for all the other chains.
Scaling Considerations
none
Upgrade Considerations
There has been some discussion of versions for
feedPolicy. This PR doesn't add anything in that area. The block height of the vstorage write can be used as one form of version number, though that isn't available to the contract, so it wouldn't let the contract detect OCW reports based on outdated policies.