feat(vats): ERTP face on orch assets, take 3 #10456
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-orch-purse-3
branch
from
663f638
to
77011ce
Compare
Deploying agoric-sdk with
|
| Latest commit: |
ef65261
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://db46a9b8.agoric-sdk.pages.dev |
| Branch Preview URL: | https://markm-orch-purse-3.agoric-sdk.pages.dev |
erights
force-pushed
the
markm-orch-purse-3
branch
2 times, most recently
from
e320322
to
1a36c17
Compare
This was referenced Nov 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
closes: #XXXX refs: #XXXX ## Description For some reason, vscode does successfully highlight unused jsdoc type imports  but `yarn lint` does not  This PR started as a drive-by extracted from #10456 , where I noticed that ERTP in particular had some of these. Since #10456 experiments with a variation on ERTP, simplifying it first in harmless ways helps a bit. ### Security Considerations fewer distractions helps ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations none ### Upgrade Considerations In the agoric-sdk repo there are no remaining type imports of the legacy type reexport of `Baggage` from ertp. But if there are such imports in other repos, they will need to be fixed. But this is a static-only issue, not a runtime issue, so it's fine for those repos to be fixed only once they depend on the new `@agoric/ertp` without that legacy reexport.
erights
force-pushed
the
markm-orch-purse-3
branch
from
1a36c17
to
8aaf3b9
Compare
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
closes: #XXXX refs: #XXXX ## Description orchestration/src/typeGuards was defining and exporting some patterns as just unhardened object literals. This is locally wrong, since these are not valid patterns (or even passables) until hardened. The only reason these errors were uncaught must be because they were then used in a context which happened to harden them before they were used in a context where they were validated as patterns or passables. Started as a drive-by of #10456 , where I import some of these patterns for usage elsewhere. ### Security Considerations defensive hardening is good ### Scaling Considerations none ### Documentation Considerations one less thing we would need to explain ### Testing Considerations In theory, a test could have revealed the bug that these were exported unhardened. But IMO, such tests would only be too much noise. We should just fix these. But this PR only fixes these in this one file. I don't know how many others there are. ### Upgrade Considerations In theory, it is possible that some importing code somewhere accidentally replies on these being unhardened, perhaps because it mutates one in place before using it, corrupting use by all other importers. If so, this PR will break such uses, which is good, because the silent corruption is a worse surprise than a new noisy error.
erights
force-pushed
the
markm-orch-purse-3
branch
4 times, most recently
from
b30ce82
to
0b6eecb
Compare
erights
force-pushed
the
markm-orch-purse-3
branch
from
0b6eecb
to
ef65261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #10443
Likely to be closed in favor of #10504
closes: #XXXX
refs: #XXXX
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations