remove tsimp #10325
Merged
remove tsimp #10325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
8e23534
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2b0c5c4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://ta-no-tsimp.agoric-sdk.pages.dev |
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
4 tasks
turadg
force-pushed
the
ta/no-tsimp
branch
2 times, most recently
from
ec496f7 to
ce1befa
Compare
Closed
no need for tsimp, these tests look at `dist`/ . There's also the `tsc` option for compilation, but it ignores our `tsconfig.build.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incidental
Description
Latest
tsimpis pulling in Rimraf v6 which breaks install under Node 18.Replace one use of
tsimpwith https://bloomberg.github.io/ts-blank-space/The other import was never used so it simply removes it
Security Considerations
fewer deps
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI suffices
Upgrade Considerations
none