Skip to content

Commit

Permalink
chore: resolve withdrawToSeat TODO with comment
Browse files Browse the repository at this point in the history
  • Loading branch information
0xpatrickdev committed Dec 9, 2024
1 parent c5de989 commit db3ced7
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions packages/fast-usdc/src/exos/settler.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,12 @@ export const prepareSettler = (
const split = calculateSplit(received);
log('disbursing', split);

// TODO: what if this throws?
// arguably, it cannot. Even if deposits
// and notifications get out of order,
// we don't ever withdraw more than has been deposited.
// If this throws, which arguably can't occur since we don't ever
// withdraw more than has been deposited, funds will remain in the
// `settlementAccount`. A remediation can occur in a future upgrade.
await vowTools.when(
withdrawToSeat(
// @ts-expect-error Vow vs. Promise stuff. TODO: is this OK???
// @ts-expect-error LocalAccountMethods vs OrchestrationAccount
settlementAccount,
settlingSeat,
harden({ In: received }),
Expand Down

0 comments on commit db3ced7

Please sign in to comment.