Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stale "latest" image #128

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix stale "latest" image #128

merged 3 commits into from
Mar 12, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 11, 2024

closes: #121

Test plan

Pushing the "latest" image shouldn't build anything. Confirmed by manually triggering the workflow to get the steps that are skipped in normal PRs. https://github.com/Agoric/agoric-3-proposals/actions/runs/8250580844/job/22565552157

Push "latest" image                10s

Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the symptoms are gone.

ghcr.io/agoric/agoric-3-proposals latest 66d5553b0fd6 18 hours ago 3.3GB
Digest: sha256:f3f99ecdbb318d63f484bf5d62bd47014cb457d1da0fc1e3de6cabe424c93303

@@ -142,17 +142,33 @@ jobs:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turadg turadg marked this pull request as ready for review March 12, 2024 17:11
@turadg turadg enabled auto-merge March 12, 2024 18:36
@turadg
Copy link
Member Author

turadg commented Mar 12, 2024

CI is failing on #93

This did pass in a manual trigger so I'm going to override the CI check to get it into master. I'll fiddle with the CI flakiness there.

@turadg turadg disabled auto-merge March 12, 2024 19:17
@turadg turadg merged commit 754a8d1 into main Mar 12, 2024
1 of 2 checks passed
@turadg turadg deleted the 121-bundle-cost branch March 12, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle cost is 100x too high in latest image
2 participants