Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for py38 & uv chore upgrade #606

Merged
merged 6 commits into from
Dec 30, 2024
Merged

Drop support for py38 & uv chore upgrade #606

merged 6 commits into from
Dec 30, 2024

Conversation

teocns
Copy link
Contributor

@teocns teocns commented Dec 27, 2024

🎯 Purpose

Replace tox with uv for testing and dependency management to improve CI speed, simplify configuration, and modernize our tooling. Drop support for Python 3.8 (and lower) as it reached its EOL

image

🤔 Reasoning

  1. Why UV?

    • 5-10x faster dependency resolution than pip
    • Better caching support in CI
    • Modern Python packaging features
    • Simpler configuration in pyproject.toml
    • Active development and community support
  2. CI Testing:

  • Workflow will automatically test against Python 3.9-3.13
  • Coverage reports will be generated and uploaded to Codecov

📈 Performance Impact

  • CI execution time expected to improve by 40-60%
  • Dependency resolution time reduced by 5-10x
  • Improved caching reduces subsequent run times

🔍 Additional Notes

  • UV is maintained by the Ruff team, ensuring long-term support
  • Migration is backward compatible - users can still use pip if preferred
  • No changes to test code required

@teocns teocns force-pushed the replace-tox-with-uv branch 2 times, most recently from 92d1bff to c2264ed Compare December 28, 2024 00:24
@teocns teocns marked this pull request as draft December 28, 2024 00:27
@teocns teocns force-pushed the replace-tox-with-uv branch 8 times, most recently from fc6b492 to 9a772f0 Compare December 29, 2024 22:30
@teocns teocns changed the title Replace tox with uv Drop support for py38 & uv chore upgrade Dec 30, 2024
@teocns teocns force-pushed the replace-tox-with-uv branch 3 times, most recently from ea71387 to 374ec12 Compare December 30, 2024 03:42
Signed-off-by: Teo <[email protected]>
@teocns teocns force-pushed the replace-tox-with-uv branch 2 times, most recently from f429196 to ded5a31 Compare December 30, 2024 06:17
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 37.53% <100.00%> (-14.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/client.py 65.53% <100.00%> (ø)
agentops/helpers.py 56.04% <ø> (ø)

... and 12 files with indirect coverage changes

@teocns teocns marked this pull request as ready for review December 30, 2024 06:22
@teocns teocns enabled auto-merge (squash) December 30, 2024 06:22
@teocns teocns requested a review from areibman December 30, 2024 06:23
@teocns teocns force-pushed the replace-tox-with-uv branch from b786bc7 to 371c086 Compare December 30, 2024 19:47
@teocns
Copy link
Contributor Author

teocns commented Dec 30, 2024

  • Reverted some devin tests that are poorly implemented and misusing the async loop causing CI to timeout

  • Reverted 82f9bb9 as support for <= 3.8 is dropped and it defeats the purpose of the commit

Copy link
Member

@the-praxs the-praxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@teocns teocns merged commit 47285a9 into main Dec 30, 2024
9 checks passed
@teocns teocns deleted the replace-tox-with-uv branch December 30, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants