-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Llama Stack support via its Python client #530
[FEAT] Llama Stack support via its Python client #530
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic High Entropy Secret | ae572ba | examples/llama_stack_client_examples/fireworks-server-config.yaml | View secret |
- | - | Generic High Entropy Secret | b131246 | examples/llama_stack_client_examples/fireworks-server-config.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Hey @thaddavis congrats for your first PR! good job!! 👏 |
Signed-off-by: Teo <[email protected]>
bb35885
to
ec8445d
Compare
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚨 Try these New Features:
|
…s for future reference
…ter live demo to Maintainers team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@areibman I made some changes so this looks cleaner now.
Although I approve this, there are some bugs in the Llama Stack which we need to look at later.
📥 Pull Request
📘 Description
This is the v1 of support for monitoring Llama Stack applications via the LlamaStackClient class
🧪 Testing
Included a smoke test for standard completions and completions with streaming in the tests/core_manual_tests/providers/llama_stack_client_canary.py file