Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Llama Stack support via its Python client #530

Merged

Conversation

thaddavis
Copy link
Contributor

@thaddavis thaddavis commented Nov 23, 2024

📥 Pull Request

📘 Description
This is the v1 of support for monitoring Llama Stack applications via the LlamaStackClient class

🧪 Testing
Included a smoke test for standard completions and completions with streaming in the tests/core_manual_tests/providers/llama_stack_client_canary.py file

Copy link

gitguardian bot commented Nov 23, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret ae572ba examples/llama_stack_client_examples/fireworks-server-config.yaml View secret
- - Generic High Entropy Secret b131246 examples/llama_stack_client_examples/fireworks-server-config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@teocns
Copy link
Contributor

teocns commented Nov 23, 2024

Hey @thaddavis congrats for your first PR!
Looks very good to me, I'll just do some cleaning for you since 1. the commit history leaks an API key, 2) your branch was based on an older version of upstream and does not pass styling (auto format commit hook was recently added)

good job!! 👏

@teocns teocns force-pushed the tduval/feature/llamaStackClientSupport branch from bb35885 to ec8445d Compare November 23, 2024 05:17
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 20.20202% with 79 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/llms/llama_stack_client.py 20.87% 72 Missing ⚠️
agentops/llms/__init__.py 12.50% 7 Missing ⚠️
Flag Coverage Δ
unittests 54.67% <20.20%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/llms/__init__.py 25.00% <12.50%> (-1.09%) ⬇️
agentops/llms/llama_stack_client.py 20.87% <20.87%> (ø)

🚨 Try these New Features:

@teocns teocns requested a review from the-praxs November 23, 2024 05:21
@thaddavis thaddavis changed the title Tduval/feature/llama stack client support tduval/feature/llama stack client support Nov 24, 2024
agentops/llms/llama_stack_client.py Outdated Show resolved Hide resolved
@areibman areibman linked an issue Nov 29, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@the-praxs the-praxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areibman I made some changes so this looks cleaner now.

Although I approve this, there are some bugs in the Llama Stack which we need to look at later.

@the-praxs the-praxs changed the title tduval/feature/llama stack client support [FEAT] Llama Stack support via its Python client Dec 7, 2024
@the-praxs the-praxs requested review from areibman and teocns December 10, 2024 09:17
@the-praxs the-praxs added the enhancement New feature or request label Dec 10, 2024
@the-praxs the-praxs enabled auto-merge (squash) December 10, 2024 17:52
@the-praxs the-praxs disabled auto-merge December 10, 2024 18:38
@the-praxs the-praxs enabled auto-merge (squash) December 10, 2024 18:38
@the-praxs the-praxs merged commit 89a301b into AgentOps-AI:main Dec 10, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Meta LlamaStack Support
5 participants