Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Fix linting and formatting for the CI tests to pass 100% #523

Closed
wants to merge 4 commits into from

Conversation

the-praxs
Copy link
Member

📥 Pull Request

📘 Description

  • Linting and formatting the files using the ruff tool so that the CI tests pass
  • Add rules in the pre-commit hook to ensure only required rules are checked

🧪 Testing
TODO

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 54.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/llms/anthropic.py 11.29% <ø> (ø)

🚨 Try these New Features:

@teocns
Copy link
Contributor

teocns commented Nov 21, 2024

What's the backstory behind this PR's initiative? Let's get add more details specifically addressing

@the-praxs
Copy link
Member Author

What's the backstory behind this PR's initiative? Let's get add more details specifically addressing

  • Not using black, only ruff
  • CI test fails for linting so it fixes that

@teocns
Copy link
Contributor

teocns commented Nov 21, 2024

🤔 I only see general CI failures for codecov, can you help me locate the failures?

@the-praxs
Copy link
Member Author

Here's the commit from #522 where a lot of unrelated files weren't linted.

I opened this PR to fix linting for these files so that it's on main and update the rules in pyproject.toml, if required after discussion.

@teocns
Copy link
Contributor

teocns commented Nov 22, 2024

agentops/pyproject.toml

Lines 72 to 106 in 517c93e

exclude = [
".bzr",
".direnv",
".eggs",
".git",
".git-rewrite",
".github",
".hg",
".ipynb_checkpoints",
".mypy_cache",
".nox",
".pants.d",
".pyenv",
".pytest_cache",
".vscode",
".pytype",
".ruff_cache",
".svn",
".tox",
".venv",
".vscode",
"__pypackages__",
"_build",
"buck-out",
"build",
"dist",
"docs",
"examples",
"node_modules",
"site-packages",
"venv",
"tests/core_manual_tests",
]
[tool.setuptools]

@the-praxs
Copy link
Member Author

the-praxs commented Nov 22, 2024

Barring those the main codebase was not linted.

Ah okay. Closing this.

@the-praxs the-praxs closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants