Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display url from api server if available #444

Merged
merged 3 commits into from
Oct 14, 2024
Merged

display url from api server if available #444

merged 3 commits into from
Oct 14, 2024

Conversation

siyangqiu
Copy link
Contributor

📥 Pull Request

📘 Description
If the server sends back a URL to display, display that version instead of the locally generated version

@siyangqiu siyangqiu requested a review from areibman October 14, 2024 23:33
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.59% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/client.py 70.29% <100.00%> (-0.15%) ⬇️
agentops/log_config.py 96.96% <100.00%> (ø)
agentops/session.py 61.81% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

@siyangqiu siyangqiu merged commit d04622a into main Oct 14, 2024
11 checks passed
@siyangqiu siyangqiu deleted the server-url branch October 14, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants