Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating notebooks to work with testing automation #341

Closed
wants to merge 2 commits into from

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Aug 9, 2024

📥 Pull Request

📘 Description
Adding pip installs, standardizing how we fetch env variables, and updating anything we've deprecated

🎯 Goal
Standardize the notebooks such that they can be automatically tested with test-notebooks.yml GitHub Action

🧪 Testing
test-notebooks.yml GitHub Action

@HowieG HowieG requested a review from areibman August 9, 2024 05:48
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 45.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

* Adding notebook testing automation (#340)

* Fixing path in GitHub action

* Renaming job action and updating notebook

* Testing new notebook

* Standardizing notebooks

* More updating more testing

* More standardizing

* Updating more notebooks

* Testing all ipynb directly under examples

* Standardizing notebooks

* Updating notebooks

* adding branch to action

* typo

* Updating Action to read agentops.log for each notebook. Fixing recording-events.ipynb

* Fixing Action to save agentops.log

* Fixing Action

* iterating workflow

* Should continue executing notebooks when one fails

* Workflow now for all ipynb. Fixing lots of notebooks

* Fixing notebooks

* Adding multion key

* workflow finishing touches
Copy link

gitguardian bot commented Aug 9, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12083425 Triggered Generic High Entropy Secret fc99a6f tests/core_manual_tests/agentchat_agentops.ipynb View secret
12083425 Triggered Generic High Entropy Secret fc99a6f tests/core_manual_tests/agentchat_agentops.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant