Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added gifs and banner images #261

Merged
merged 9 commits into from
Jun 20, 2024
Merged

added gifs and banner images #261

merged 9 commits into from
Jun 20, 2024

Conversation

areibman
Copy link
Contributor

📥 Pull Request

📘 Description
Updated screenshots, logos, and gifs. Will be used to update other notebooks across the web

@bboynton97
Copy link
Contributor

these are cool! do we want to add them to the README as well?

@bboynton97
Copy link
Contributor

I'm not sure that we want to include these in this repo though. it adds 20MB to the repo size. we may be better off hosting in a bucket or having a separate repo for assets

@areibman
Copy link
Contributor Author

I'm not sure that we want to include these in this repo though. it adds 20MB to the repo size. we may be better off hosting in a bucket or having a separate repo for assets

If they're going to be in docs anyway, I think it makes sense to just host it on Github which is free, has versioning, and is an effective CDN. I can't really name any other public docs sites that use external image hosting, and I also see a ton of repos with .mp4's in the readme

Copy link

gitguardian bot commented Jun 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@areibman areibman changed the title [DRAFT] added gifs and banner images added gifs and banner images Jun 20, 2024
@areibman areibman requested a review from bboynton97 June 20, 2024 22:23
@bboynton97
Copy link
Contributor

If they're going to be in docs anyway, I think it makes sense to just host it on Github which is free, has versioning, and is an effective CDN. I can't really name any other public docs sites that use external image hosting, and I also see a ton of repos with .mp4's in the readme

We could look into using git LFS. I believe GitHub automatically offers a certain amount of blob storage to be used with LFS. Blobs/binary files still get an immutable and versioned pointer, but the file isn't stored in the repo, rather on a CDN

@areibman areibman merged commit a28eba1 into main Jun 20, 2024
8 checks passed
@areibman areibman deleted the screenshot-gifs branch June 20, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants