Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding serialization functionality and multion examples #236

Merged
merged 26 commits into from
Jun 5, 2024
Merged

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Jun 1, 2024

  • Fixing tuple (only available in python3.9+) to Tuple (from typing module)
  • Changing auto_start_session default to True only if init() was explicitly called. Otherwise had bug where initializing Client singleton with record_function() would auto_start_session when it was just being decorated. Meaning partner frameworks where agentops was integrated but optional (e.g. multion) would try to start_session() even if user didn't explicitly use agentops.
  • Automatically assigning screenshot from returns.screenshot to ActionEvent.screenshot for convenience for partners (multion)
  • Updating safe_serialize to also call any available json(), to_dict(), or dict() formatting functions
  • Updating remove_none_values to remove_unwanted values (None, ... (ellipsis which multion OMITs), and self)

@HowieG HowieG requested a review from siyangqiu June 1, 2024 01:29
Copy link

gitguardian bot commented Jun 1, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10824647 Triggered Generic High Entropy Secret faad6a8 docs/mint.json View secret
10824647 Triggered Generic High Entropy Secret 775e6e0 docs/mint.json View secret
11373238 Triggered Generic High Entropy Secret 870cf9b examples/multion_step_session_example.ipynb View secret
11373238 Triggered Generic High Entropy Secret 7468115 examples/multion_step_session_example.ipynb View secret
11373239 Triggered Generic High Entropy Secret 870cf9b examples/multion_step_session_example.ipynb View secret
11373239 Triggered Generic High Entropy Secret 7468115 examples/multion_step_session_example.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@HowieG HowieG requested a review from bboynton97 June 1, 2024 01:29
@HowieG HowieG enabled auto-merge (squash) June 5, 2024 06:06
agentops/helpers.py Outdated Show resolved Hide resolved
examples/multion_example_browse.ipynb Outdated Show resolved Hide resolved
examples/multion_example_retrieve.ipynb Outdated Show resolved Hide resolved
examples/multion_example_step_session.ipynb Outdated Show resolved Hide resolved
examples/multion_example_step_stream.ipynb Outdated Show resolved Hide resolved
examples/multion_example_step_stream.ipynb Outdated Show resolved Hide resolved
examples/multion_example_browse.ipynb Outdated Show resolved Hide resolved
agentops/client.py Show resolved Hide resolved
agentops/client.py Show resolved Hide resolved
@bboynton97 bboynton97 requested a review from areibman June 5, 2024 18:29
@HowieG HowieG dismissed areibman’s stale review June 5, 2024 19:18

Shawn+Braelyn on board for auto_start_session

@HowieG HowieG merged commit cc7c399 into main Jun 5, 2024
6 of 7 checks passed
@HowieG HowieG deleted the multion-example branch June 5, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants