Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set end timestamp if not set before record #179

Merged
merged 4 commits into from
May 3, 2024
Merged

set end timestamp if not set before record #179

merged 4 commits into from
May 3, 2024

Conversation

bboynton97
Copy link
Contributor

Closes ENG-330

If the developer does not set an end_timestamp, calling record() will set it

@bboynton97 bboynton97 requested review from siyangqiu and HowieG May 2, 2024 23:08
@bboynton97 bboynton97 changed the title send end timestamp if not set before record set end timestamp if not set before record May 2, 2024
@bboynton97 bboynton97 merged commit 2a0ee73 into main May 3, 2024
2 checks passed
@bboynton97 bboynton97 deleted the event-end-timestamp branch May 3, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowieG HowieG HowieG approved these changes

@siyangqiu siyangqiu Awaiting requested review from siyangqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboynton97 @HowieG