Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chatml validation from sdk #127

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Remove chatml validation from sdk #127

merged 6 commits into from
Apr 2, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Mar 28, 2024

📥 Pull Request

📘 Description
Moving chatml coercion to api server so removing from here

@HowieG HowieG requested review from siyangqiu and bboynton97 March 28, 2024 08:54
@HowieG
Copy link
Contributor Author

HowieG commented Mar 28, 2024

Don't merge yet. Need to update api

agentops/client.py Outdated Show resolved Hide resolved
@HowieG HowieG changed the title DRAFT remove chatml validation from sdk Remove chatml validation from sdk Apr 2, 2024
@HowieG HowieG force-pushed the eng-128-rework-chatml branch from afefb95 to 87d890a Compare April 2, 2024 02:25
Copy link
Contributor

@siyangqiu siyangqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dupes, but otherwise good

agentops/langchain_callback_handler.py Show resolved Hide resolved
agentops/event.py Outdated Show resolved Hide resolved
agentops/llm_tracker.py Outdated Show resolved Hide resolved
agentops/llm_tracker.py Show resolved Hide resolved
@HowieG HowieG merged commit 45005bd into main Apr 2, 2024
1 of 2 checks passed
@HowieG HowieG deleted the eng-128-rework-chatml branch April 2, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants