Skip to content

Commit

Permalink
style fix (#630)
Browse files Browse the repository at this point in the history
Fix style in pr #608
Signed-off-by: Teo <[email protected]>
  • Loading branch information
teocns authored Jan 9, 2025
1 parent ad5a17f commit 8f92278
Showing 1 changed file with 10 additions and 22 deletions.
32 changes: 10 additions & 22 deletions tests/test_decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@

class TestDecorators:
# Test data
Point = namedtuple('Point', ['x', 'y'])
Person = namedtuple('Person', ['name', 'age'])
Point = namedtuple("Point", ["x", "y"])
Person = namedtuple("Person", ["name", "age"])
# Custom namedtuple to test specific subclass behavior mentioned in PR
CustomTuple = namedtuple('CustomTuple', ['data'])
CustomTuple = namedtuple("CustomTuple", ["data"])

@pytest.fixture(autouse=True)
def setup(self):
Expand Down Expand Up @@ -100,48 +100,36 @@ def test_json_serialization(self):

# Test with regular tuple
direct_tuple = (1, "test")
event1 = ActionEvent(
action_type="test_action",
params={"test": "params"},
returns=direct_tuple
)
event1 = ActionEvent(action_type="test_action", params={"test": "params"}, returns=direct_tuple)
event1_dict = filter_unjsonable(event1.__dict__)
event1_json = json.dumps(event1_dict)
assert event1_json, "Event with tuple returns should be JSON serializable"

# Verify the serialized data structure
event1_data = json.loads(event1_json)
assert isinstance(event1_data["returns"], list), "JSON naturally converts tuples to lists"
assert event1_data["returns"] == [1, "test"], "Tuple data should be preserved in JSON"

# Test with named tuple
named_tuple = self.Point(x=1, y=2)
event2 = ActionEvent(
action_type="test_action",
params={"test": "params"},
returns=named_tuple
)
event2 = ActionEvent(action_type="test_action", params={"test": "params"}, returns=named_tuple)
event2_dict = filter_unjsonable(event2.__dict__)
event2_json = json.dumps(event2_dict)
assert event2_json, "Event with named tuple returns should be JSON serializable"

# Verify the serialized data structure
event2_data = json.loads(event2_json)
assert isinstance(event2_data["returns"], list), "JSON naturally converts named tuples to lists"
assert event2_data["returns"] == [1, 2], "Named tuple data should be preserved in JSON"

# Test with custom tuple subclass
custom_tuple = self.CustomTuple(data={"key": "value"})
event3 = ActionEvent(
action_type="test_action",
params={"test": "params"},
returns=custom_tuple
)
event3 = ActionEvent(action_type="test_action", params={"test": "params"}, returns=custom_tuple)
event3_dict = filter_unjsonable(event3.__dict__)
event3_json = json.dumps(event3_dict)
assert event3_json, "Event with custom tuple subclass should be JSON serializable"

# Verify the serialized data structure
event3_data = json.loads(event3_json)
assert isinstance(event3_data["returns"], list), "JSON naturally converts custom tuples to lists"
assert event3_data["returns"] == [{"key": "value"}], "Custom tuple data should be preserved in JSON"
assert event3_data["returns"] == [{"key": "value"}], "Custom tuple data should be preserved in JSON"

0 comments on commit 8f92278

Please sign in to comment.