Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop test telemetry logging #194

Merged
merged 2 commits into from
Jan 7, 2025
Merged

stop test telemetry logging #194

merged 2 commits into from
Jan 7, 2025

Conversation

bboynton97
Copy link
Contributor

📥 Pull Request

📘 Description
GitHub CI was currently logging telemetry, this stops that

@bboynton97 bboynton97 requested a review from tcdent January 7, 2025 19:14
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentstack/telemetry.py 0.00% 5 Missing ⚠️
Flag Coverage Δ
unittests 53.01% <0.00%> (-13.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentstack/telemetry.py 0.00% <0.00%> (ø)

... and 21 files with indirect coverage changes

@bboynton97 bboynton97 merged commit 6bcbe71 into main Jan 7, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcdent tcdent tcdent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboynton97 @tcdent