Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update telemetry with result and error #160

Merged
merged 2 commits into from
Dec 21, 2024
Merged

update telemetry with result and error #160

merged 2 commits into from
Dec 21, 2024

Conversation

bboynton97
Copy link
Contributor

📥 Pull Request

📘 Description
Telemetry now stores the result of the command and error messages to better support users

🧪 Testing
Tested locally

@bboynton97 bboynton97 requested a review from tcdent December 21, 2024 11:54
tcdent
tcdent approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@tcdent tcdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run it!

Of note: I made some changes to exception handling in the logging PR, but I'll update with this pattern before the merge.

@bboynton97 bboynton97 merged commit 1efdf66 into main Dec 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcdent tcdent tcdent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboynton97 @tcdent