Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unable to recursive parsing the UNION clause #96

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

git-hulk
Copy link
Member

This closes #93

@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10629722228

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 59.386%

Totals Coverage Status
Change from base Build 10570485618: 0.04%
Covered Lines: 6156
Relevant Lines: 10366

💛 - Coveralls

@git-hulk git-hulk requested a review from Lance726 August 30, 2024 08:50
@git-hulk
Copy link
Member Author

@Lance726 The root cause parseSelectQuery will recursively parse the UNION clause but parseSelectStatment would limit to the SELECT clause only.

@git-hulk git-hulk merged commit 8ce79cd into AfterShip:master Aug 30, 2024
1 check passed
@Lance726
Copy link
Collaborator

@Lance726 The root cause parseSelectQuery will recursively parse the UNION clause but parseSelectStatment would limit to the SELECT clause only.

OK, get it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] multi-level linked UNION statements are not supported
3 participants