Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling T64, DoubleDelta, Gorilla codec #83

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Handling T64, DoubleDelta, Gorilla codec #83

merged 3 commits into from
Jul 17, 2024

Conversation

sharadgaur
Copy link
Contributor

@sharadgaur sharadgaur commented Jul 17, 2024 •
edited
Loading

#84

@coveralls
Copy link

coveralls commented Jul 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9975669089

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 58.28%
Totals Coverage Status
Change from base Build 9954625564: 0.004%
Covered Lines: 5951
Relevant Lines: 10211
💛 - Coveralls

@git-hulk
Copy link
Member

Hi @sharadgaur Thanks for your contribution. Would you mind adding the test SQLs to cover this?

@sharadgaur
Copy link
Contributor Author

sure give me 10 min.

@sharadgaur
Adding test
0addd6a 
Signed-off-by: Sharad Gaur <[email protected]>
@sharadgaur
Copy link
Contributor Author

Hi @sharadgaur Thanks for your contribution. Would you mind adding the test SQLs to cover this?

Done

git-hulk
git-hulk approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@git-hulk git-hulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@git-hulk git-hulk merged commit 6a6d450 into AfterShip:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadgaur @coveralls @git-hulk