Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: convert to monorepo #18

Merged
merged 7 commits into from
Sep 27, 2023
Merged

chore: convert to monorepo #18

merged 7 commits into from
Sep 27, 2023

Conversation

RicardoD4W
Copy link
Contributor

🧵 Descripción

Creo que he arraglao' esto del monorepo

🎨 Tipo del cambio

Por favor selecciona las opciones que apliquen en tu PR.

  • Frontend
  • Backend
  • Configuración
  • Documentación
  • Bug fix (cambio no radical que soluciona un problema)
  • New feature (cambio no radical que añade funcionalidad)
  • Breaking change (solución o característica que haría que la funcionalidad existente no funcionara como se esperaba)

🧪 ¿Cómo puede ser testeado?

  • Realiza un cambio en el código (front/back)
  • git add .
  • git commit -m "commit msg"
  • Si el archivo modificado en cuestión se linteó, todo OK :)

🧩 Otra información

@owlnai owlnai changed the title feat: making a monorepo chore!: convert to monorepo Sep 27, 2023
owlnai
owlnai reviewed Sep 27, 2023
View reviewed changes
.github/CODE_OF_CONDUCT.md Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿Por qué se ha borrado?

package.json Outdated
"lint": "eslint . --ext js,jsx --report-unused-disable-directives --max-warnings 0",
"lint:fix": "npm run lint -- --fix",
"preview": "vite preview",
"dev": "pnpm --recursive dev",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferiría usar pnpm run -r dev (o el que aplique) puesto que es más explícito y puede evitar futuras colisiones con PNPM

owlnai
owlnai reviewed Sep 27, 2023
View reviewed changes
package.json Outdated
"type": "module",
"version": "0.0.0",
"private": true,
"version": "1.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "1.0.0",
"version": "1.0.0",
"private": true,
"packageManager": "[email protected]",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versión 1.0.0 ?? esta verde esto aun no?

@owlnai owlnai mentioned this pull request Sep 27, 2023
Closed
7 tasks
@JavierBalonga
Copy link
Collaborator

Lo que es la carpeta apps/back no la subas porfa.
Nos sirvió para hacer las pruebas de que el linter anduviera correctamente.
Pero sácalo así eso ya lo suben correctamente cuando encaren las apis

JavierBalonga
JavierBalonga reviewed Sep 27, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
JavierBalonga
JavierBalonga reviewed Sep 27, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@JavierBalonga JavierBalonga changed the title chore!: convert to monorepo chore: convert to monorepo Sep 27, 2023
@JavierBalonga JavierBalonga linked an issue Sep 27, 2023 that may be closed by this pull request
Chore: Convert to a monorepo #19
Closed
@JavierBalonga JavierBalonga merged commit de86922 into Afordin:main Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owlnai owlnai owlnai left review comments

@JavierBalonga JavierBalonga JavierBalonga approved these changes

Assignees

@RicardoD4W RicardoD4W

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Convert to a monorepo
3 participants
@RicardoD4W @JavierBalonga @owlnai