New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor, deprecation fixes and tasks flow improved #7

Open

RafalNiewinski wants to merge 3 commits into AerisCloud:master from RafalNiewinski:master

RafalNiewinski commented Nov 23, 2017

Redesigned system and user installations:

Removed code duplicates with sudo atrribute.
Removed sudo attribute which is not supported currently in ansible.

If system installation needs to escalate it should be done like this:

roles:
  { role: AerisCloud.rvm, become: true, become_user: root, become_method: sudo }`

Changed tasks to to properly report state:

Failed - only when real error occurs
Changed - when some action needed and job done with success
Ok - in other cases when action is not required or for check actions

Warnings resolved:

include changed to include_tasks for task inclusion due to deprecation
Muted warning about using curl in shell because ansible recommends other module

RafalNiewinski added 3 commits

November 23, 2017 11:15


          Refactoring and ansible compatibility fixes

20b6a24


          include => include_tasks because deprecated

d2c45d0


          Mute warning in task where we using curl in shell

412f64c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet