Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update processing provider based on PR 354 #388

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

r-akemii
Copy link
Collaborator

@r-akemii r-akemii commented Dec 4, 2024

This PR updates the processing provider tools based on @Art-Ev contributions in #354.

We:

  • Refactored code in qaequilibrae/modules/processing_provider whenever necessary
  • Added missing tests
  • Updated documentation and its screenshots

@r-akemii r-akemii marked this pull request as ready for review December 10, 2024 17:16
@r-akemii
Copy link
Collaborator Author

@Art-Ev could you please take a look at the modifications I did based on #354?

@Art-Ev
Copy link
Contributor

Art-Ev commented Dec 11, 2024

@Art-Ev could you please take a look at the modifications I did based on #354?

Yep, will give that a look tomorrow

@@ -88,3 +89,8 @@ def only_str(str_input):
if isinstance(str_input, bytes):
return str_input.decode("utf-8")
return str_input


def polygon_from_radius(point: Point, radius):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approximation is too rough for most of our uses. Isn't there a better default solution in QGIS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at the available functions, but a better solution might exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants