New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use "CRITICAL" stream for standard logging #219

Draft

jamiecook wants to merge 1 commit into develop from jamiecook-patch-1

Collaborator

jamiecook commented May 18, 2023 •

edited

Loading

This should help to address confusion like #214
We could also do something like

level = Info
if "WARNING" in line:
    level = Warning
if "ERROR" in line:
    level = Critical
log(line, level)

NOTE: Code is currently untested.


          Not critical

621d7bb

jamiecook changed the title ~~Not critical~~ Don't use "CRITICAL" stream for standard logging

jamiecook requested a review from pedrocamargo

May 18, 2023 19:37

jamiecook marked this pull request as draft

May 18, 2023 19:37

pedrocamargo approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet