Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes centroid connector creation #584

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Fixes centroid connector creation #584

merged 4 commits into from
Nov 1, 2024

Conversation

pedrocamargo
Copy link
Contributor

@pedrocamargo pedrocamargo commented Oct 28, 2024

Fixes the creation of centroid connectors by replacing the entire process with something based on GeoPandas.

QAequilibraE will have to change because of this, @r-akemii , but we can worry about that only after merging this PR. A few items still missing:

  • Tests
  • Documentation

There are minor changes to the API, but this is mostly used through QAequilibraE

closes #550

@pedrocamargo pedrocamargo added the WIP Work in Progress label Oct 28, 2024
@pedrocamargo pedrocamargo self-assigned this Oct 28, 2024
@pedrocamargo pedrocamargo removed the WIP Work in Progress label Oct 28, 2024
@r-akemii r-akemii merged commit 523611d into develop Nov 1, 2024
16 checks passed
@r-akemii r-akemii deleted the pedro/new_connectors branch November 1, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connect_mode - generated connectors are not connecting to the nearest node [v1.0.1]
2 participants