Resolved issue #110, int64 is correct #126
Conversation
|
Dammit. I've never investigated this myself but I keep seeing back-and-forts PRs. Are some protobuf implementations simply not unpacking the data correctly? Yo @Grover-c13 step in and check it out. Also #110 |
|
can not get it working with fixed64 in java. It is strange that most work with fixed64 except for this one for java. i assume youre using PHP simplyphp? |
|
The data type might not be either of these two. Protobuf is designed that you can swop out certain types for others and it will try its best. From https://developers.google.com/protocol-buffers/docs/proto#updating So it could actutally be one of these other types and protobuf is just casting. Has anyone tried the other compatible types? |
|
You may be right, i was just checking the original master game file leak (http://pastebin.com/SBdB0VPL) and for some reason its marked as int64 instead of uint64 like most other protos (there is one other exception marked as int64 and thats EggIncubatorProto). Tested on java and working as normal int64, can you confirm when you get the chance @SimplyPHP |
|
I'm using C#, the current value uint64 does not work. |
|
Please try int64 |
|
Just to clarify, in the proto definition :P |
|
Right, this will take me a few minutes |
|
Resolved with int64. |
|
Updated my commit. |
|
Awesome, mystery solved. please comment it though with a link to this PR or something so people know not to change it. |
|
Done |
BornSupercharged
changed the title
|
Eh alright so we're flying with signed integers now? Sure. Happily awaiting your next PR. |
|
Suspiciously not signed rubenvereecken/pokemongo-api#93 |
No description provided.