Update charon #83
Open
Update charon #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
update-charon
branch
from
c222e20
to
95d3a3e
Compare
|
I'll review this on Friday after the paper submission deadlines -- this looks like a delicate PR, thanks! |
Nadrieril
force-pushed
the
update-charon
branch
from
95d3a3e
to
f150400
Compare
Nadrieril
force-pushed
the
update-charon
branch
from
f150400
to
831877e
Compare
msprotz
approved these changes
Nov 16, 2024
| let ts = | ||
| match sub_e.typ with | ||
| | TTuple ts -> ts | ||
| | _ -> assert false |
There was a problem hiding this comment.
so the issue with tuples of length 1 has been fixed upstream?
There was a problem hiding this comment.
ah I see, the early-return case is still up there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to AeneasVerif/charon#457 which changes how we represent places in charon. In particular, charon now stores the type of each place. I use this to simplify
expression_of_place.