Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies to dune-project file #452

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Nadrieril
Copy link
Member

@giltho like this?

@giltho
Copy link

giltho commented Nov 4, 2024

(menhir :build) is needed in name_matcher_parser's package definition

@giltho
Copy link

giltho commented Nov 4, 2024

After installing menhir that seems to be enough :)
Happy to do one last check from fresh switch before you merge if needed

@Nadrieril
Copy link
Member Author

(menhir :build) is needed in name_matcher_parser's package definition

Done, would you mind one last check?

@giltho
Copy link

giltho commented Nov 4, 2024

Ah sorry I should have been clearer, (menhir :build) is a dependency requirement, it means menhir is needed as a build dependency. So it needs to be in the list of dependencies:

(package
  (name name_matcher_parser)
  (synopsis "Parser to define name matchers")
  (description "")
  (depends
    (menhir :build)
    menhirLib
    ppx_deriving
    visitors
    zarith
  )
 )

@giltho
Copy link

giltho commented Nov 4, 2024

I'm sorry, I should have just fixed it myself...
opam is weird like this, it's so difficult to get these things right it's annoying.

@Nadrieril
Copy link
Member Author

how about now?

@giltho
Copy link

giltho commented Nov 4, 2024

Opam files need to be regenerated 😭

@Nadrieril
Copy link
Member Author

o no x)

@Nadrieril
Copy link
Member Author

And now?

@giltho
Copy link

giltho commented Nov 4, 2024

image

Success!! Thank you!

@Nadrieril
Copy link
Member Author

Nadrieril commented Nov 4, 2024

Hooray! Thanks for walking me through this 😁

@Nadrieril Nadrieril merged commit 2193aa0 into AeneasVerif:main Nov 4, 2024
6 checks passed
@Nadrieril Nadrieril deleted the fix-opam branch November 4, 2024 16:35
@Nadrieril Nadrieril mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants