Stop sorting const functions differently #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we call `hax_def` to explore the crate, we eagerly evaluate constant-level things anyway.
Nadrieril
force-pushed
the
no-sort-const-fns
branch
from
3d3ad50
to
886ccf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we eagerly call
hax_defon the items of the crate, the order in which we translate items doesn't matter anymore. I'm therefore removing the process that sorted const fns before other items to avoid stealing issues.There does remain work to be done before we can properly handle
after_analysisstealing all themir_builts though.