Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift clauses on associated types to be clauses on the whole trait #290

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Nadrieril
Copy link
Member

Dinstinguishing trait clauses defined on an associated type versus those defined as a where clause on the whole trait does not seem useful. What's meaningful is distinguishing clauses that are required to mention the trait versus clauses that are implied by the trait. We already make this distinction: required clauses are in the TraitDecl.generics field, implied clauses are in TraitDecl.parent_clauses.

This PR moves all the type Item: Trait clauses to be where Self::Item: Trait parent clauses on the trait to simplify clause management. This is done as a post-processing pass. I would have liked to to this when we translate clauses, but I'll leave that for later when generics are easier to follow.

@Nadrieril
Copy link
Member Author

For the CI checks:

  • check-version-number failure is a false positive because the json format hasn't changed;
  • aeneas is indeed failing, which is fixed in the companion PR;
  • kyber has a build issue since the last eurydice update, which is independent from charon. This might be hiding breakage caused by this PR, but if so it should only be some easy-to-fix name changes.

@Nadrieril Nadrieril merged commit 3f02eee into AeneasVerif:main Jul 16, 2024
3 of 6 checks passed
@Nadrieril Nadrieril deleted the lift-item-clauses branch July 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant