Add support for traits #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR of AeneasVerif/charon#48, which describes most of the modifications (see below for the modifications specific to Aeneas). This PR also subsumes #35.
In order to properly handle associated types in the presence of type constraints (e.g.,
where Foo::U = U32) we implemented a normalization mechanism (inAssociatedTypes.ml). This mechanism operates on the LLBC types. As we would need a similar mechanism to type-check the generated pure code, we temporarily deactivated the type checking sanity checks fromPureTypeCheck.ml.Because Charon removed many "assumed" definitions, we implemented a mechanism to catch definitions (like
Vec,Option,core::mem::replace, etc.) that we want to map to definitions from the standard library. For now, the definitions we catch are hardcoded inExtractBuiltin.ml, but it would be pretty easy to give the possibility of listing them in a file which would be parsed by Aeneas (this is future work).In order to make the tests work, we also substantially modified and extended the current standard libraries.