Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8452] Update maximum giftcard discount allowed to transaction limit #406

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

SushmitaThakur
Copy link
Contributor

@SushmitaThakur SushmitaThakur commented Aug 4, 2023

Summary

For when redeeming giftcards during checkout, If there is a transaction limit specified, use that as a balance amount instead of the actual balance on the gift card.

Tested scenarios

  1. When product price is less than the transaction limit
  2. When product price is greater than the transaction limit
  3. When the transaction limit is same as balance

@SushmitaThakur SushmitaThakur requested a review from a team as a code owner August 4, 2023 10:49
@SushmitaThakur SushmitaThakur changed the title Ecp 8452 [ECP 8452] Update maximum giftcard discount allowed to transaction limit Aug 4, 2023
@SushmitaThakur SushmitaThakur changed the title [ECP 8452] Update maximum giftcard discount allowed to transaction limit [ECP-8452] Update maximum giftcard discount allowed to transaction limit Aug 4, 2023
@candemiralp candemiralp merged commit 936772d into develop Aug 9, 2023
8 of 9 checks passed
@candemiralp candemiralp deleted the ECP-8452 branch August 9, 2023 08:51
@candemiralp candemiralp mentioned this pull request Aug 10, 2023
@candemiralp candemiralp added the Fix Indicates a bug fix label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants