Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8518] Unset amqp in config to use default queue connection #2654

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

factorin-j
Copy link
Contributor

@factorin-j factorin-j commented Jun 16, 2024

Description

  • remove amqp in queue xml config to use Magento's default (db) connection if amqp service is not installed.
  • include additional admin message when using 'queue' notification processing
  • add unit tests

Tested scenarios

  • Tested using 2 Magento setups:
    • bin/magento setup:install with opensearch/elasticsearch only
    • bin/magento setup:install with --amqp-* options included (RabbitMQ installed).
  • Unit test output:
docker compose exec -it php vendor/bin/phpunit -c dev/tests/unit/phpunit.xml app/code/Adyen/Payment/Test/Unit/Model/Queue/
PHPUnit 9.5.24 #StandWithUkraine

...                                                                                                                                                                                                                                                3 / 3 (100%)

Time: 00:00.047, Memory: 22.00 MB

OK (3 tests, 8 assertions)

Fixes #2031

@andreusala
Copy link

@factorin-j I have encountered an issue related to the adyen.notification consumer in Magento 2, where it attempts to use an amqp connection even though we have configured it to use cron. I came across a pull request that seems to address this problem.

Could you please provide an update on the development status of this PR? Is there a planned timeline for merging and releasing this fix? We are looking forward to a resolution to improve our current setup.

Thank you!

@factorin-j
Copy link
Contributor Author

@andreusala, sorry for the delayed response. I'm not certain about the timeline for this PR. We might need to coordinate with @candemiralp on this matter. In the meantime, you can refer to this comment #2031 (comment) as an initial fix if you're encountering the same issue.

- remove amqp in queue xml config to use default (db) if amqp service is not installed.
- include additional admin message when using 'queue' notification processing
- add unit tests
@candemiralp
Copy link
Member

Hello @factorin-j,

Thank you for your contribution to solve this bug. This PR will be released soon.

Best Regards,
Can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ECP-8518] New Implement option to use queue or cron causes error Unknown connection name amqp
4 participants