Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPT-119] Mentorship 2024 Launch #810

Merged
merged 13 commits into from
Jul 21, 2024
Merged

[MPT-119] Mentorship 2024 Launch #810

merged 13 commits into from
Jul 21, 2024

Conversation

wei2912
Copy link
Member

@wei2912 wei2912 commented Jul 17, 2024

TODO:

  • Merge in [MPT-62] [MPT-106] adjust width on faq #787 + FAQ should be vertically aligned (even top/bottom padding)
  • Change to yearless logo
  • Update partners
  • Fix preview image issue
  • Switch to 2024 wave
  • Apply Now button should look the same between navbar and below
  • Apply Now should open in new tab

This PR should be rebased (with --autosquash) before merging.

@wei2912 wei2912 changed the title 2024 launch Mentorship 2024 Launch Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for tender-meitner-99286b ready!

Name Link
🔨 Latest commit bea8602
🔍 Latest deploy log https://app.netlify.com/sites/tender-meitner-99286b/deploys/669b66631f1b8a0008e47638
😎 Deploy Preview https://deploy-preview-810--tender-meitner-99286b.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94
Accessibility: 97
Best Practices: 100
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@wei2912 wei2912 self-assigned this Jul 17, 2024
@wei2912 wei2912 marked this pull request as draft July 17, 2024 11:04
@wei2912 wei2912 linked an issue Jul 17, 2024 that may be closed by this pull request
@wei2912 wei2912 changed the title Mentorship 2024 Launch [MPT-119] Mentorship 2024 Launch Jul 17, 2024
Copy link

linear bot commented Jul 17, 2024

@Hackin7
Copy link
Contributor

Hackin7 commented Jul 18, 2024

LGTM so far, the important (Apply Now) Link is working and Q&A is updated

@wei2912
Copy link
Member Author

wei2912 commented Jul 20, 2024

Deferring merging of #787 to @jcc-kh's judgment cos I personally am not sure if I agree with the style choices, and so far nobody has complained about the sizing of the FAQ text.

Switch to 2024 wave has been made, but the lambda will only be deployed upon merge into main.

@wei2912
Copy link
Member Author

wei2912 commented Jul 20, 2024

Testimonials have been disabled, to be addressed in #812.

@wei2912 wei2912 requested a review from Hackin7 July 20, 2024 07:26
@wei2912 wei2912 marked this pull request as ready for review July 20, 2024 07:26
@wei2912
Copy link
Member Author

wei2912 commented Jul 20, 2024

@Hackin7 would need your help to confirm that 2024 mentors are being correctly loaded after merge.

Copy link
Contributor

@Hackin7 Hackin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, though there are a lot of comments that should be settled soon after the Mentorship wave

Mentor loading code looks ok, but I'll merge in and see how

@Hackin7 Hackin7 merged commit 639b555 into main Jul 21, 2024
12 checks passed
@Hackin7 Hackin7 deleted the 2024-launch branch July 21, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare website for Mentorship 2024
2 participants