Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream1911 #806

Merged
merged 301 commits into from
Dec 14, 2024
Merged

Upstream1911 #806

merged 301 commits into from
Dec 14, 2024

Conversation

Schrodinger71
Copy link
Collaborator

@Schrodinger71 Schrodinger71 commented Nov 19, 2024

О пулл реквесте

АПСТРИМ!!

Требования

  • Я прочитал(а) и следую Руководство по созданию пулл реквестов. Я понимаю, что в противном случае мой ПР может быть закрыт по усмотрению мейнтейнера.
  • Я добавил скриншоты/видео к этому пулл реквесту, демонстрирующие его изменения в игре, или этот пулл реквест не требует демонстрации в игре

Критические изменения

TaskBoard к починке апстрима:

  • Content.Server\Weapons\Ranged\Systems\GunSystem.cs @Inconnu1337
    image
    Требует Тестов

  • обратить внимание на
    Content.Shared\Store\ListingPrototype.cs
    скорее всего тут всё норм
    image
    image
    image

  • Content.Shared\Interaction\SharedInteractionSystem.Clumsy.cs
    был удалён, а у нас там изменения
    image

  • Изменить Ccvar. из за рефакторинга всё съехало

Ccvar

CVarDef.Create("server.rules_file", "ADTRuleset", CVar.REPLICATED | CVar.SERVER); //ADT tweak rule
CVarDef.Create("admin.new_player_threshold", 600, CVar.ARCHIVE | CVar.REPLICATED | CVar.SERVER); // ADT-Tweak
CVarDef.Create("game.contraband_examine", false, CVar.SERVER | CVar.REPLICATED); ///ADT no wizard cringe
CVarDef.Create("ahelp.admin_prefix", true, CVar.SERVERONLY); // ADT-Tweak
CVarDef.Create("atmos.space_wind", true, CVar.SERVERONLY); ///ADT
CVarDef.Create("shuttle.emergency_early_launch_allowed", true, CVar.SERVERONLY); //ADT-Tweak - включен ранний запуск аварийного шаттла командованием
CVarDef.Create("shuttle.emergency_dock_time", 300f, CVar.SERVERONLY); //ADT-Tweak - время стыковки эвакшаттла увеличен до 5 минут
CVarDef.Create("shuttle.emergency_authorize_time", 30f, CVar.SERVERONLY); //ADT-Tweak - предупреждение о запуске за 30 секунд до отправки
CVarDef.Create("shuttle.auto_call_time", 270, CVar.SERVERONLY); //ADT-Tweak - автоматический эвак вызывается после 3 часов
CVarDef.Create("viewport.maximum_width", 29, CVar.REPLICATED | CVar.SERVER); //ADT 16:9
CVarDef.Create("viewport.width", 29, CVar.CLIENTONLY | CVar.ARCHIVE); //ADT 16:9
CVarDef.Create("chat.max_announcement_length", 700, CVar.SERVER | CVar.REPLICATED);// ADT Tweak 256
CVarDef.Create("infolinks.appeal", "https://discord.com/channels/901772674865455115/1245787985891561544", CVar.SERVER | CVar.REPLICATED); //ADT-Tweak: Ссылка на обжалование

  • добавить забытые CCVAR @FaDeOkno

CCVAR КОТОРЫЕ НИГДЕ НЕ БЫЛИ ОТМЕЧЕНЫ "ADT" ИЗ ЗА ЧЕГО Я ИХ ПРИКРЕПЛЯЮ ПРОСТО СКРИНОМ БИЛДИНГА. ПАСИБА ЗА ПОДСТАВУ

image

  • Просто проверить обратить внимание на Resources\Prototypes\Entities\Objects\Devices\pda.yml
    image

  • Тут были закоменчены 28, 85 commented эти строки Content.Shared\ADT\Crawling\Systems\SharedCrawlingSystem.cs, BonkSystem удалили? @FaDeOkno

Чейнджлог

🆑 Шрёдька, Пётр, Инконну, и какой-то там КэшРаш на пару с Даркичем.

  • tweak: Подтянуты коммиты с Корвакса, 19.11.2024

VasilisThePikachu and others added 30 commits November 1, 2024 21:34
* Add on-call functionality for adminning

The first time an ahelp gets SOS it gets relayed to the specified channel with the specified ping. Every time after that it doesn't until it gets a non-SOS response received.

* Remove redundant name

Pretty sure this already gets chucked on the name of the msg itself I think it just didn't show in screenshot because they were subsequent.

* Update Content.Server/Administration/Systems/BwoinkSystem.cs

Co-authored-by: Chief-Engineer <[email protected]>

---------

Co-authored-by: Chief-Engineer <[email protected]>
Co-authored-by: deathride58 <[email protected]>
* idk how to revert a pr so I just deleted some lines

* pill destructible with explosion resistance

* comment for explosion resist

* "and" to "but"

---------

Co-authored-by: SlamBamActionman <[email protected]>
* med lathe gauze price reduction

* gauze craft doafter time

* 3 second doafter craft
* add

* Revert "add"

This reverts commit 25da34b0fead5812fe5800c9bf5dd7b10ef48d7d.

* antagonism allowed:tm:
* Changes the AME sound effect to not be the default MetalThud.

* Was told on discord to make a minor change to autorerun the tests due to the Build & Test Debug failing!

* Attribution and licensing, as requsted by deathride58

* Fixes the high-pitched squeak audible to some people!

* Audio file tweaked by SlamBamActionMan to eliminate a weird squeak they were still able to hear. Thanks!
* Allow for the ai's laws to be changed from its core and eye

* Address reviews
* clean up tools lathe recipes

* add medical and cooking tools

* add result

* add result to others

* review

* engine

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
* Deduping of recent messages should consider the channel it's being sent to

* rerun actions
added headphones to trinkets
* capacity upgrade

* comment update
* Add debug messages to traitor activation

* more debug
* Adds storage sprites for combat knife and survival knife. Replaces inhand sprites.

* Fixes meta.json copyright
fix broken computer white shadows
Make wielding system use identity
* Make ghost roles collapsible

* Save `BodyVisible` state of each `Collapsible` box

* Make ghost role collapsible only when group has more than 1 role

* Make it a little prettier

* Make only ghost role buttons collapsible

* Apply requested changes

* Typo

* Small cleanup

* Store in list, instead of iterating

* Make unique ids more unique

* Move it out of the cycle

* Make _collapsibleBoxes into dictionary and use key instead of Collapsible boxes names

Added TODO. So after the problem will be fixed in `GhostRolesEui`, it should be mirrored and fixed here too.

* Put TODO in GhostRolesEui. I guess Issue must be made for this

* Use HashSet instead of Dictionary as suggested. Invert the HashSet, so being present means it uncollapsed

I decided to invert HashSet to _uncollapsedStates, because players surely will have more collapsed buttons than opened, so we optimise memory usage a little bit.

* Remove extra space from ghost roles window

* Add buttons stretching. Size 3:1
@github-actions github-actions bot added the Changes: Localization Изменение локализации label Nov 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PyotrIgn PyotrIgn merged commit 83fdd24 into master Dec 14, 2024
13 checks passed
@PyotrIgn PyotrIgn deleted the upstream1911 branch December 14, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Изменение локализации Changes: Map Изменение карт Changes: Sprites Изменение спрайтов Changes: UI Изменение интерфейса
Projects
None yet
Development

Successfully merging this pull request may close these issues.