Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: fix function_codes for example tcp server #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hrbonz
Copy link

@hrbonz hrbonz commented Apr 16, 2020

the function codes used in write_data_store are to write registers but
the example code for server/client deals with coils everywhere else. The
example scripts are correct but the README got it wrong.

the function codes used in `write_data_store` are to write registers but
the example code for server/client deals with coils everywhere else. The
example scripts are correct but the README got it wrong.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.861% when pulling 77402a2 on hrbonz:wip/fix_readme_code_example into 749d69f on AdvancedClimateSystems:master.

@rgov
Copy link
Contributor

rgov commented Jul 25, 2020

What about using the constants from umodbus.functions instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants