Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nimitha/embed docs overview revamp #181

Merged
merged 11 commits into from
Dec 6, 2024

Conversation

nimithajalal
Copy link
Collaborator

@nimithajalal nimithajalal commented Oct 28, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nimithajalal nimithajalal requested a review from undavide October 28, 2024 09:44
Copy link
Collaborator

@undavide undavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits aside, great work! 👍🏼👍🏼👍🏼

src/pages/guides/index.md Outdated Show resolved Hide resolved
src/pages/guides/index.md Show resolved Hide resolved
src/pages/guides/index.md Show resolved Hide resolved
@nimithajalal nimithajalal merged commit 10bc1c8 into main Dec 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants