Update Discord in vpn_services.json #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added more discord domains
jellizaveta
requested changes
Oct 9, 2024
source/vpn_services.json
Outdated
| @@ -133,11 +133,27 @@ | |||
| "MESSENGERS" | |||
| ], | |||
| "domains": [ | |||
| "discord-attachments-uploads-prd.storage.googleapis.com", | |||
There was a problem hiding this comment.
Hello. I'm not sure about adding these domains, they look suspicious, some don't open.
discordsays.com
discordactivities.com
discordpartygames.com
discord.store
discordapp.com
discord.design
There was a problem hiding this comment.
discord.dev redirected to https://discord.com/developers/docs/intro
Are these domains really needed?
Alex-302
requested changes
Oct 9, 2024
| "discord.com", | ||
| "discord.design", |
There was a problem hiding this comment.
Where used? It seems not related to discord.
| "discord.media", | ||
| "discord.new", |
| "discord.media", | ||
| "discord.new", | ||
| "discord.store", |
There was a problem hiding this comment.
Not required for discord operation.
| "discord.media", | ||
| "discord.new", | ||
| "discord.store", | ||
| "discord.tools", |
| "discordapp.com", | ||
| "discordapp.net", | ||
| "discordcdn.com", | ||
| "discordmerch.com", |
There was a problem hiding this comment.
Not required for discord operation.
| "discordapp.com", | ||
| "discordapp.net", | ||
| "discordcdn.com", | ||
| "discordmerch.com", | ||
| "discordpartygames.com", |
There was a problem hiding this comment.
Where used? Looks like not working.
| "discordcdn.com", | ||
| "discordmerch.com", | ||
| "discordpartygames.com", | ||
| "discord-activities.com", |
| "discordmerch.com", | ||
| "discordpartygames.com", | ||
| "discord-activities.com", | ||
| "discordactivities.com", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added more discord domains