fix: get rid of restart variables to stop all related crashes

[OH296]

Description of changes

• stop scr_restart_variables function running
• remove restart variable at save load speeding up save load

Reasons for changes

Related links

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Remove the restart variables and the related function calls.

Bug Fixes:

• Prevent crashes related to the restart variables.

Enhancements:

• Improve save/load performance by removing restart variables.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR removes the scr_restart_variables function and associated restart variables to improve save/load performance and prevent related crashes. A new function reset_creation_variables is introduced to handle variable initialization during chapter creation.

File-Level Changes

Change	Details	Files
Removed the scr_restart_variables function and all calls to it.	Deleted the entire body of the scr_restart_variables function and replaced it with a new function called reset_creation_variables. Replaced calls to scr_restart_variables with reset_creation_variables in the obj_creation object's Create_0 event. Removed calls to scr_restart_variables from the obj_controller object's Alarm_0 and Alarm_1 events. Removed calls to scr_restart_variables and the creation of obj_restart_vars from the obj_saveload object's Alarm_1 event. Removed the creation of obj_restart_vars and the call to scr_restart_variables from the scr_initialize_custom script	scripts/scr_restart_variables/scr_restart_variables.gml objects/obj_creation/Create_0.gml objects/obj_controller/Alarm_1.gml objects/obj_controller/Alarm_0.gml objects/obj_saveload/Alarm_1.gml scripts/scr_initialize_custom/scr_initialize_custom.gml
Removed restart variables from the save/load scripts.	Deleted the code that writes restart variables to the save file in scr_save. Deleted the code that reads restart variables from the save file in scr_load.	scripts/scr_load/scr_load.gml scripts/scr_save/scr_save.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please fill out the testing checklist in the PR description to document what scenarios have been validated

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}