-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new skitarii base sprite #409
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new sprite for Skitarii units. The sprite is displayed when rendering Skitarii units. A new sprite resource File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OH296 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the 'Reasons for changes' section to provide context for why this new sprite is being added.
- Could you please verify which test scenarios you've completed by checking the appropriate boxes in the testing section?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OH296 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please fill out the 'Reasons for changes' section to provide context for the PR
- The test checkboxes should be marked for the tests you've performed - at minimum, please verify compilation and basic in-game display
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description of changes
Reasons for changes
Related links
How have you tested your changes?
Summary by Sourcery
New Features: