refactor: First company command gear/size assign

[EttyKitty]

Description of changes

• Streamline how first command squad gets their equipment assigned.
• Do the same for their unit size.
• Move all unit generation of the first comp under the vet+term check, as I see no reason not to.
• Remove unused var _spawn_unit.
• Replace a weird for loop on rhino spawn with repeat(4).

Reasons for changes

• Fix Librarian loadout.
• Make stuff more readable and less typo prone, I hope.

Related links

• https://discord.com/channels/714022226810372107/1301585908696481903

How have you tested your changes?

• Compile
• New game
• Next turn
• Space Travel
• Ground Battle

Summary by Sourcery

Refactor the first company command squad gear and size assignment logic. Apply veteran and terminator checks to all unit generation. Replace the rhino spawn loop with a repeat loop.

Enhancements:

• Streamline the equipment and unit size assignment for the first company command squad.

Tests:

• Compile and start a new game to test changes.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR refactors the first company command squad gear and size assignment logic, applying veteran and terminator checks to all unit generations and simplifying the equipment and unit size assignments. It also replaces a for loop with a repeat loop for rhino spawns and removes an unused variable.

File-Level Changes

Change	Details	Files
Streamlined first company command squad gear/size assignment.	Defined helper functions _is_terminator to check for terminator armor and variables to manage first company armor, weapons, and size based on veteran/terminator status. Used these variables and functions to streamline the logic for assigning gear and size to the first company command squad based on the presence of terminators and veterans. Removed repetitive armor assignment blocks within the veteran check.	scripts/scr_initialize_custom/scr_initialize_custom.gml
Moved unit generation under veteran/terminator check.	Moved all unit generation logic for the first company under the veteran + terminator check.	scripts/scr_initialize_custom/scr_initialize_custom.gml
Removed unused variable and replaced for loop.	Removed the unused _spawn_unit variable. Replaced the for loop used for Rhino spawning with a repeat(4) loop.	scripts/scr_initialize_custom/scr_initialize_custom.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes - here's some feedback:

Overall Comments:

• Remove commented debug message on line 2582

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

The base branch was changed.

[OH296]

@sourcery-ai review

[sourcery-ai]

Hey @EttyKitty - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}