Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Complex Components for Tartaros Armour #342

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 28, 2024

  • Tartaros right and left leg components
  • Tartaros chest components
  • new complex area key "gorget"
  • Tartaros gorget components

I'm no artist this is as good as i can do i'm afraid

Copy link
Contributor

sourcery-ai bot commented Dec 28, 2024

Reviewer's Guide by Sourcery

This pull request adds support for Tartaros pattern right and left legs, chest, and gorget pieces. It introduces a new complex area key "gorget" to support the new components. The changes involved updating the get_complex_set function to include the new sprites and modifying the scr_draw_unit_image and TTRPG_stats functions to handle the new gorget area.

File-Level Changes

Change Details Files
Added Tartaros right and left leg components. Added new sprites for the right and left legs.
  • Created spr_tartaros_right_leg sprite.
  • Created spr_tartaros_left_leg sprite.
sprites/spr_tartaros_right_leg/spr_tartaros_right_leg.yy
sprites/spr_tartaros_left_leg/spr_tartaros_left_leg.yy
Added Tartaros chest components. Added new sprites for the chest.
  • Created spr_tartaros_chest sprite.
sprites/spr_tartaros_chest/spr_tartaros_chest.yy
Added Tartaros gorget components. Added new sprites for the gorget.
  • Created spr_tartaros_gorget sprite.
sprites/spr_tartaros_gorget/spr_tartaros_gorget.yy
Added new complex area key "gorget". Updated functions to handle the new gorget area.
  • Added "gorget" key to the get_complex_set function.
  • Added handling for the "gorget" key in the scr_draw_unit_image function.
  • Added "throat" variant to the TTRPG_stats function.
scripts/scr_draw_unit_image/scr_draw_unit_image.gml
scripts/scr_marine_struct/scr_marine_struct.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added PR: Sprites Changes to sprites/images PR: Feature Adds something new labels Dec 28, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty
Copy link
Collaborator

EttyKitty commented Dec 28, 2024

I've decided against just pushing into this PR, as you may not like what I did, so please check this PR for your PR.

OH296#37

@OH296 OH296 merged commit abf8770 into Adeptus-Dominus:release/0.10.0.0 Dec 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Feature Adds something new PR: Sprites Changes to sprites/images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants