Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Tweaks to grav weapon as per play testing #339

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

OH296
Copy link
Collaborator

@OH296 OH296 commented Dec 27, 2024

Summary by Sourcery

Increase the damage of the Grav-Pistol and add maintenance values for grav weapons.

Copy link
Contributor

sourcery-ai bot commented Dec 27, 2024

Reviewer's Guide by Sourcery

This pull request balances grav weapons by increasing the Grav-Pistol's damage and adding maintenance values for all grav weapons.

File-Level Changes

Change Details Files
Increased Grav-Pistol damage.
  • Increased standard damage from 100 to 150.
  • Increased master_crafted damage from 110 to 200.
  • Increased artifact damage from 120 to 250.
scripts/scr_weapon/scr_weapon.gml
Added maintenance values for grav weapons.
  • Added a maintenance value of 0.8 to the Grav-Pistol.
  • Added a maintenance value of 0.1 to the Grav-Gun.
  • Added a maintenance value of 0.2 to the Grav-Cannon.
scripts/scr_weapon/scr_weapon.gml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a missing comma after the "tags": ["grav", "heavy_weapon"] line for the Grav-Cannon
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty self-assigned this Dec 27, 2024
Copy link
Contributor

@EttyKitty EttyKitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OH296,
Maintenance stuff is okay.
Damage increase is okay, as a temporary measure before EttyKitty#163 comes in.

One issue with the comma, as the bot noted.
Also, "balance" commit type doesn't exist. The closest you can get, is probably feat(balance).

scripts/scr_weapon/scr_weapon.gml Outdated Show resolved Hide resolved
@EttyKitty
Copy link
Contributor

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The damage scaling between standard/master/artifact Grav-Pistol variants (150/200/250) is much steeper than the original (100/110/120). Was this intentional as part of the rebalancing?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@EttyKitty EttyKitty changed the title balance: Tweaks to grav equipment as per play testing balance: Tweaks to grav weapon as per play testing Dec 27, 2024
@EttyKitty
Copy link
Contributor

I was trying to force a PR title check, but I think because it doesn't exist on the 0.10 branch or yours, it can't get executed.
So, I'll just manually change the title.

@EttyKitty EttyKitty changed the title balance: Tweaks to grav weapon as per play testing feat(balance): Tweaks to grav weapon as per play testing Dec 27, 2024
@EttyKitty EttyKitty merged commit 43cd424 into Adeptus-Dominus:release/0.10.0.0 Dec 27, 2024
@EttyKitty EttyKitty added the PR: Balance Noticeably affects game balance label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Balance Noticeably affects game balance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants