-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balance): Tweaks to grav weapon as per play testing #339
feat(balance): Tweaks to grav weapon as per play testing #339
Conversation
Reviewer's Guide by SourceryThis pull request balances grav weapons by increasing the Grav-Pistol's damage and adding maintenance values for all grav weapons. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OH296 - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a missing comma after the
"tags": ["grav", "heavy_weapon"]
line for the Grav-Cannon
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OH296,
Maintenance stuff is okay.
Damage increase is okay, as a temporary measure before EttyKitty#163 comes in.
One issue with the comma, as the bot noted.
Also, "balance" commit type doesn't exist. The closest you can get, is probably feat(balance)
.
Co-authored-by: EttyKitty <[email protected]>
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @OH296 - I've reviewed your changes - here's some feedback:
Overall Comments:
- The damage scaling between standard/master/artifact Grav-Pistol variants (150/200/250) is much steeper than the original (100/110/120). Was this intentional as part of the rebalancing?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I was trying to force a PR title check, but I think because it doesn't exist on the 0.10 branch or yours, it can't get executed. |
Summary by Sourcery
Increase the damage of the Grav-Pistol and add maintenance values for grav weapons.