fix: Possible over running of array length with ship weapons

[OH296]

Summary by Sourcery

Bug Fixes:

• Prevent crashes caused by mismatched array lengths when accessing ship weapons and their facing directions.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request fixes a potential array overrun error when accessing ship weapons. The change introduces a check for the lengths of ship_wep and ship_wep_facing arrays and uses the minimum of the two lengths and 5 to prevent accessing elements beyond the array bounds. A loop iterates up to this calculated maximum, ensuring that weapon and facing data are accessed safely.

File-Level Changes

Change	Details	Files
Prevent potential array overrun errors when accessing ship weapons.	Added array_length checks for both obj_ini.ship_wep_facing and obj_ini.ship_wep arrays. Used min function to determine the maximum number of weapons to process, preventing potential out-of-bounds access. Replaced direct array accesses with a loop that iterates up to the calculated maximum number of weapons. The loop now dynamically assigns values to cn.temp based on the current weapon index, ensuring correct data population.	scripts/scr_fleet_advisor/scr_fleet_advisor.gml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @OH296 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[OH296]

sourcery-ai review

[EttyKitty]

@sourcery-ai review

[sourcery-ai]

Hey @OH296 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The original code handled 4 weapons (indices 1-4), but the new code uses 5 as the maximum in min(). Was this intentional? If not, consider changing max_weapons to 4 to maintain the same behavior.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}